Unload #1752
Merged
Unload #1752
+290
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessibility Violations Found
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
vdua
reviewed
Nov 20, 2025
vdua
reviewed
Nov 20, 2025
ui.frontend/src/GuideBridge.js
Outdated
| '.cmp-adaptiveform-recaptcha__widget', | ||
| '.cmp-adaptiveform-turnstile__widget', | ||
| '.cmp-adaptiveform-hcaptcha__widget', | ||
| '.datePickerTarget' |
Collaborator
There was a problem hiding this comment.
This points to the fact that we need to have a better mechanism for widget selectors.
Collaborator
Author
There was a problem hiding this comment.
yes, this cannot be changed at this time, most probably this selector came from v1
vdua
reviewed
Nov 20, 2025
vdua
reviewed
Nov 20, 2025
ui.frontend/src/GuideBridge.js
Outdated
| // Clear DatePicker cache | ||
| // afCache stores datepicker instances keyed by element IDs | ||
| if (window.afCache && typeof window.afCache.store === 'object') { | ||
| window.afCache.store = {}; |
Collaborator
There was a problem hiding this comment.
what about multiple forms in a page.
Collaborator
Author
There was a problem hiding this comment.
This cache is a global store, we can't remove this as per the current implementation
vdua
reviewed
Nov 20, 2025
Accessibility Violations Found
|
5 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
sakshi-arora1
approved these changes
Nov 20, 2025
ui.frontend/src/GuideBridge.js
Outdated
| window.xfalib.ut = null; | ||
| } | ||
| if (window.formBridge && typeof window.formBridge.destroyForm === 'function') { | ||
| window.formBridge.destroyForm(); |
Contributor
There was a problem hiding this comment.
this should be called if the form is of schemaType xdp or FormTemplate, irrespective if it is last form or not.
Accessibility Violations Found
|
3 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: