Skip to content

FORMS-21799 fixing aria-label to display plain text #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 23, 2025
Merged

FORMS-21799 fixing aria-label to display plain text #1715

merged 5 commits into from
Sep 23, 2025

Conversation

@im-shiv
Copy link
Contributor

@im-shiv im-shiv commented Sep 17, 2025

No description provided.

sakshi-arora1
sakshi-arora1 reviewed Sep 17, 2025
View reviewed changes
sakshi-arora1
sakshi-arora1 reviewed Sep 17, 2025
View reviewed changes
sakshi-arora1
sakshi-arora1 reviewed Sep 17, 2025
View reviewed changes
Copy link
Contributor

@sakshi-arora1 sakshi-arora1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this needs to be fixed in Rich text labels for all components, with tests

options needed special handling and I added TOFix, since I was fixing dynamic behaviour of checkbox group and radio button in code and test cases
@im-shiv
Copy link
Contributor Author

im-shiv commented Sep 18, 2025

Also this needs to be fixed in Rich text labels for all components, with tests

options needed special handling and I added TOFix, since I was fixing dynamic behaviour of checkbox group and radio button in code and test cases

we don't have aria-label attribute for labels in core-components
@sakshi-arora1
Copy link
Contributor

sakshi-arora1 commented Sep 18, 2025

Also this needs to be fixed in Rich text labels for all components, with tests
options needed special handling and I added TOFix, since I was fixing dynamic behaviour of checkbox group and radio button in code and test cases

we don't have aria-label attribute for labels in core-components

Have you checked all components? including scribble, review, file input etc. Do this check for all components.
sakshi-arora1
sakshi-arora1 requested changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@sakshi-arora1 sakshi-arora1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditional label massaging needs to be done
@im-shiv
Copy link
Contributor Author

im-shiv commented Sep 18, 2025 •
edited
Loading

Also this needs to be fixed in Rich text labels for all components, with tests
options needed special handling and I added TOFix, since I was fixing dynamic behaviour of checkbox group and radio button in code and test cases

we don't have aria-label attribute for labels in core-components

Have you checked all components? including scribble, review, file input etc. Do this check for all components.

only switch component have aria-labels, will add relevant code to handle it
@codecov
Copy link

codecov bot commented Sep 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...core/components/util/AbstractOptionsFieldImpl.java 91.66% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!
@adobe-bot
Copy link

adobe-bot commented Sep 18, 2025

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
page-has-heading-one moderate
target-size serious
@adobe-bot
Copy link

adobe-bot commented Sep 18, 2025

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious
@adobe-bot
Copy link

adobe-bot commented Sep 19, 2025

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious
1 similar comment
@adobe-bot
Copy link

adobe-bot commented Sep 19, 2025

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious
@adobe-bot
Copy link

adobe-bot commented Sep 19, 2025

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious
1 similar comment
@adobe-bot
Copy link

adobe-bot commented Sep 19, 2025

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious
@adobe-bot
Copy link

adobe-bot commented Sep 19, 2025

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious
1 similar comment
@adobe-bot
Copy link

adobe-bot commented Sep 19, 2025

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious
@im-shiv im-shiv merged commit b839caa into dev Sep 23, 2025
9 checks passed
@im-shiv im-shiv deleted the FORMS-21799 branch September 30, 2025 09:34
rismehta added a commit that referenced this pull request Oct 8, 2025
@rismehta @im-shiv @armaang1729
Dev master8 oct (#1727)
951cb08 
* FORMS-21799 fixing aria-label to display plain text (#1715)

* FORMS-21799 fixing aria-label to display plain text

* FORMS-21799 correcting naming convention

* FORMS-21799 adding tests

* FORMS-21799 increasing test coverage

* FORMS-21799 increasing test coverage

---------

Co-authored-by: Shivam Agarwal <shivama@adobe.com>

* Merge pull request #1713 from adobe/FORMS-21742

Feat: added the loader to avoid multiple submits and tests

* Fixing js doc (#1721)

* @releng updating af-core (#1726)

* @releng updating af-core

* @releng updating af-core

---------

Co-authored-by: Shivam Agarwal <47965724+im-shiv@users.noreply.github.com>
Co-authored-by: Shivam Agarwal <shivama@adobe.com>
Co-authored-by: armaang1729 <armaang@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@im-shiv @sakshi-arora1 @adobe-bot