Scribble component #1569
Open
Scribble component #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
WIP, Looking for early feedback. |
rajatofficial
force-pushed
the
scribble-component
branch
from
4b5c8ac to
2ece48e
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1569 +/- ##
============================================
- Coverage 82.32% 82.10% -0.23%
Complexity 1000 1000
============================================
Files 108 109 +1
Lines 2603 2610 +7
Branches 370 371 +1
============================================
Hits 2143 2143
- Misses 272 279 +7
Partials 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
| ELEMENT cmp-adaptiveform-scribble__clearsign-content | ||
| ELEMENT cmp-adaptiveform-scribble__clearsign-message | ||
| ELEMENT cmp-adaptiveform-scribble__clearsign-panel | ||
| ELEMENT cmp-adaptiveform-scribble__clearsign-cancel-button cmp-adaptiveform-scribble__button--secondary |
Contributor
There was a problem hiding this comment.
can you also change this
| ELEMENT cmp-adaptiveform-scribble__controlpanel | ||
| ELEMENT cmp-adaptiveform-scribble__controls | ||
| ELEMENT cmp-adaptiveform-scribble__control-brush | ||
| MODIFIER cmp-adaptiveform-scribble__button |
Contributor
There was a problem hiding this comment.
why is this a modifier?
Contributor
There was a problem hiding this comment.
is this same for all controls?
| ELEMENT cmp-adaptiveform-scribble__control-text | ||
| MODIFIER cmp-adaptiveform-scribble__button | ||
| ELEMENT cmp-adaptiveform-scribble__control-message | ||
| ELEMENT cmp-adaptiveform-scribble__controlpanel__controls |
Contributor
There was a problem hiding this comment.
we have ELEMENT cmp-adaptiveform-scribble__controlpanel
ELEMENT cmp-adaptiveform-scribble__controls
and ELEMENT cmp-adaptiveform-scribble__controlpanel__controls as separate entities?
| ELEMENT cmp-adaptiveform-scribble__control-message | ||
| ELEMENT cmp-adaptiveform-scribble__controlpanel__controls | ||
| ELEMENT cmp-adaptiveform-scribble__button-close | ||
| ELEMENT cmp-adaptiveform-scribble__save-button |
Contributor
There was a problem hiding this comment.
lets keep consistent either button pre-appended or appended across items
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.