Skip to content

Conversation

@konradpabjan
Copy link
Contributor

@konradpabjan konradpabjan commented Oct 25, 2023

Part of https://github.com/github/actions-results-team/issues/1987

The upcoming v2.0.0 NPM packages already returns the ID of the artifact that was just created/uploaded.

https://github.com/actions/toolkit/blob/fe3e7ce9a7f995d29d1fcfd226a32bca407f9dc8/packages/artifact/src/internal/shared/interfaces.ts#L17-L21

We just need to be expose this output in this action.

Tested with this example run: https://github.com/bbq-beets/testing-artifacts-v4/actions/runs/6645936116/job/18058310425

image

Also I'm doing some other misc changes

  • Bump node runtime from 16 to 20. 16 will start deprecation soonish so we should just use the latest version
  • Doc changes, there are still a lot to go but I'm starting to make some changes
@konradpabjan konradpabjan marked this pull request as ready for review October 25, 2023 21:04
@konradpabjan konradpabjan requested a review from a team as a code owner October 25, 2023 21:04
@konradpabjan konradpabjan merged commit aa5cae1 into v4-beta Oct 26, 2023
@robherley robherley deleted the konradpabjan/v4-improvements branch December 7, 2023 00:32
tdfacer pushed a commit to ifit/upload-artifact that referenced this pull request Oct 7, 2025
* Add artifact-id to outputs

* ncc

---------

Co-authored-by: Rob Herley <robherley@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants