Add file property to AnnotationProperties
#896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also counts towards closing #186. Waiting for this merge! |
luketomlinson
approved these changes
Sep 8, 2021
Contributor
luketomlinson
left a comment
luketomlinson
left a comment
There was a problem hiding this comment.
This looks good to me @Marcono1234. Thanks for the PR! 
|
Could this PR be merged as well? 😄 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #892
Also adds missing tests for
core.notice.Feedback is appreciated, especially whether this fulfills the pull request requirements. In case you already had an internal pull request for #892, or were working locally on it, feel free to reject this pull request.