Don't erase the repository directory when clean is false and the repo isn't cloned #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the checkout directory doesn't contain .git, previously the action always erased the entire directory: now, it only does it if the clean input is true (which is the default). This means that files set-up _before_ actions/checkout is used do not get erased before cloning and checkout the repository.
|
@thboop @ericsciple Could you check this? |
|
CC: @dhadka |
tomcashman
reviewed
Jun 13, 2025
| !fsHelper.directoryExistsSync(path.join(repositoryPath, '.git')) || | ||
| repositoryUrl !== (await git.tryGetFetchUrl()) | ||
| ) { | ||
| else if (!fsHelper.directoryExistsSync(path.join(repositoryPath, '.git'))) { |
Author
There was a problem hiding this comment.
I'm not sure why you believe that?
There was a problem hiding this comment.
We tested the changes on our system and found that when the .git was present, the repo was still being cleaned out even with clean: false
Author
There was a problem hiding this comment.
That's as intended:
(if there is a
.gitdirectory, then the checks proceed as before).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, if the repository directory doesn't contain a
.gitdirectory then the action always erases the entire repository directory, regardless of the "clean" setting. This PR amends the behaviour so that forclean: falsethe directory is not erased if there's no.gitdirectory (if there is a.gitdirectory, then the checks proceed as before). It's obviously the user's responsibility (having setclean: false) to ensure that the files left in the directory don't interfere with ones which would be checked out.This was hit in ocaml/setup-ocaml@v2 (see ocaml/setup-ocaml#190). setup-ocaml v2 does some work in
_opamwhich was then being unnecessarily erased if actions/checkout was used in a later step.