fix Issue: jaroWinkler gives score > 1 for distinct strings #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: distinct strings with common prefixes get a weight > 1.0
jaroWinkler('commonlongprefixword', 'commonlongprefixworm')
Owner
|
Hello @jfseb. Thanks for noticing this one. Reading my code again, I also found some other inconsistencies, notably normally for Jaro-Winkler, the size of the common prefix should not be exceeding 4. Let me some time to document myself again more thoroughly on the metric so I can fix it correctly. |
Owner
|
@jfseb I'm gonna go ahead and merge your PR and fix the code even more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: distinct strings with common prefixes get a weight > 1.0
jaroWinkler('commonlongprefixword', 'commonlongprefixworm')
The former code easily gives weights > 1.0 for distinct strings.