fix: Update tooltip to add spacing when element has focus#3707
Merged
alanbsmith merged 4 commits intoWorkday:supportfrom Feb 2, 2026
Merged
fix: Update tooltip to add spacing when element has focus#3707alanbsmith merged 4 commits intoWorkday:supportfrom
alanbsmith merged 4 commits intoWorkday:supportfrom
Conversation
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
mc-fix-tooltio-spacing
|
| Run status |
|
| Run duration | 02m 59s |
| Commit |
|
| Committer | Manuel Carrera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
936
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
20.52%
|
|
|---|---|
|
Untested elements
|
1443
|
|
Tested elements
|
370
|
Accessibility
99.28%
|
|
|---|---|
|
Failed rules
|
6 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
98
|
mannycarrera4
commented
Jan 27, 2026
mannycarrera4
commented
Jan 27, 2026
added 2 commits
January 27, 2026 08:50
alanbsmith
reviewed
Jan 30, 2026
| padding: calc.subtract(system.space.x4, calc.divide(system.space.x1, 2)), | ||
| '&:before': { | ||
| margin: calc.add(system.space.x1, calc.divide(system.space.x1, 2)), | ||
| }, |
Member
There was a problem hiding this comment.
Comment: I never realized this was the logic to get the padding and margin. That's a very complex way to say:
padding: 14px
margin: 6px
Member
There was a problem hiding this comment.
This was the styling logic before, so I'm not asking for a change here.
Contributor
Author
There was a problem hiding this comment.
yeah i agree...
alanbsmith
approved these changes
Jan 30, 2026
alanbsmith
added
approved
10 tasks
alanbsmith
pushed a commit
that referenced
this pull request
Feb 19, 2026
Remove extra ref adding on Tooltip. This allows correct ref forwarding for Popups. [category:Components] Release Note: This [change](#3707) added an extra ref that overrides the popupStack.ref which breaks consumers passing in their own ref. Removing this should fix the issue. Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update logic in tooltip to check if the target has focus visible to add a little extra spacing
Release Category
Components
Release Note
Update logic in tooltip to check if the target has focus visible to add a little extra spacing
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)