Code Modernization: Use the null coalescing operator for isset() return checks in WP_Customize_Manager - #13304
Closed
Soean wants to merge 1 commit into
Closed
Conversation
Replaces the verbose `isset()` guard in `WP_Customize_Manager::get_setting()`, `::get_panel()`, `::get_section()`, and `::get_control()` with the null coalescing operator (`??`). Both forms are functionally identical: `??` uses the same `isset()` semantics and yields the fallback when the key is either missing or `null`. The remaining `return null` statements in the class are not this idiom — they guard on emptiness, on a `false` sentinel, or on a failed `get_userdata()` call — and are left untouched. Occurrences in `SimplePie` and `Requests` are excluded as bundled third-party code. Follow-up to [62870], [62895], [62949].
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mukeshpanchal27
approved these changes
Aug 29, 2026
pento
pushed a commit
that referenced
this pull request
Aug 31, 2026
…_Manager`. The four object getters in `WP_Customize_Manager`: `get_setting()`, `get_panel()`, `get_section()`, and `get_control()`, each spell out an `isset()` guard followed by `return null`. The null coalescing operator says the same thing in one line. `??` applies the same `isset()` semantics as the guard it replaces, and since the fallback here is `null` itself, both forms return the identical value in every case. This covers the complete set of same-shaped getters in the class. Developed in #13304. Follow-up to r63378. Props Soean, mukesh27. See #65818. git-svn-id: https://develop.svn.wordpress.org/trunk@63411 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 31, 2026
…_Manager`. The four object getters in `WP_Customize_Manager`: `get_setting()`, `get_panel()`, `get_section()`, and `get_control()`, each spell out an `isset()` guard followed by `return null`. The null coalescing operator says the same thing in one line. `??` applies the same `isset()` semantics as the guard it replaces, and since the fallback here is `null` itself, both forms return the identical value in every case. This covers the complete set of same-shaped getters in the class. Developed in WordPress/wordpress-develop#13304. Follow-up to r63378. Props Soean, mukesh27. See #65818. Built from https://develop.svn.wordpress.org/trunk@63411 git-svn-id: http://core.svn.wordpress.org/trunk@62604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Member
|
Thanks for the PR! Merged in r63411. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four object getters on
WP_Customize_Manager:get_setting(),get_panel(),get_section()andget_control(), each spell out anisset()guard followed byreturn null. The null coalescing operator says the same thing in one line.??applies the sameisset()semantics as the guard it replaces, and since the fallback here isnullitself, both forms return the identical value in every case. This covers the complete set of same-shaped getters in the class.Follow-up to [63378]
Trac ticket: https://core.trac.wordpress.org/ticket/65818
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.