Skip to content
This repository was archived by the owner on Jan 26, 2022. It is now read-only.

Remove superfluous function_exists checks#52

Closed
Ismail-elkorchi wants to merge 1 commit intoWordPress:trunkfrom
Ismail-elkorchi:remove_function_exists_checks
Closed

Remove superfluous function_exists checks#52
Ismail-elkorchi wants to merge 1 commit intoWordPress:trunkfrom
Ismail-elkorchi:remove_function_exists_checks

Conversation

@Ismail-elkorchi
Copy link
Copy Markdown

@Ismail-elkorchi Ismail-elkorchi commented Oct 7, 2021

There is no need to make the functions pluggable, since child themes can modify or remove them using remove_action/add_action.

For further background please see : WordPress/twentyseventeen#419, Automattic/_s#1116, Automattic/_s#1277
@jffng
Copy link
Copy Markdown
Collaborator

jffng commented Oct 8, 2021

Let's leave these in for now. Ideally we remove most of functions.php by the end of the theme's development anyhow. Thanks @Ismail-elkorchi
@jffng jffng closed this Oct 8, 2021
@Ismail-elkorchi
Copy link
Copy Markdown
Author

Ismail-elkorchi commented Oct 8, 2021

Ideally we remove most of functions.php by the end of the theme's development anyhow.

Even though most of the functions.php file will be removed, this PR will still apply to the remaining part. The future aspect of the code should not prevent us from sticking to good practices now.
@Ismail-elkorchi Ismail-elkorchi deleted the remove_function_exists_checks branch October 8, 2021 20:54
@kjellr kjellr mentioned this pull request Oct 14, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

[Type] Code Quality

3 participants

@Ismail-elkorchi @jffng @kjellr