Conversation
walbo
added
[Feature] Inserter
|
Size Change: -2 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d34ecf8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5303545704
|
carolinan
approved these changes
Jun 19, 2023
Contributor
carolinan
left a comment
carolinan
left a comment
There was a problem hiding this comment.
Works well, thank you.
There are still a couple of places in the UI where the arrow is incorrect, so let's keep the issue open.
Member
Author
|
Thanks. @carolinan I think the other places are already fixed, but I will double check later today and close it/create a PR to fix the rest. |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replace
chevronRightwithchevronLeftfor RTL users in the inserter.Why?
The arrows should point the other way for RTL users.
See #50721
How?
Check if the WP is running in RTL mode and serve the correct icon based on it.
Testing Instructions
Screenshots or screencast