Skip to content

Switch from unlink to wp_delete_file#163

Merged
jeffpaul merged 1 commit intoWordPress:developfrom
dkotter:fix/failing-plugin-check
Dec 23, 2025
Merged

Switch from unlink to wp_delete_file#163
jeffpaul merged 1 commit intoWordPress:developfrom
dkotter:fix/failing-plugin-check

Conversation

@dkotter
Copy link
Copy Markdown
Collaborator

@dkotter dkotter commented Dec 23, 2025

What?

Closes #160

Fixes failing Plugin Check tests

Why?

We recently updated our plugin check tests and we now have a new failure. This PR addresses that

How?

Switch from using unlink to using wp_delete_file (which uses unlink under the hood)

Testing Instructions

Not really needed but if desired, can follow testing instructions in #134

Open WordPress Playground Preview
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dkotter <dkotter@git.wordpress.org>
Co-authored-by: juanmaguitar <juanmaguitar@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.89%. Comparing base (7dbbc44) to head (2ab5a97).
⚠️ Report is 35 commits behind head on develop.

Files with missing lines Patch % Lines
includes/Abilities/Image/Import_Base64_Image.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #163   +/-   ##
==========================================
  Coverage      46.89%   46.89%           
  Complexity       208      208           
==========================================
  Files             19       19           
  Lines           1271     1271           
==========================================
  Hits             596      596           
  Misses           675      675           
Flag Coverage Δ
unit 46.89% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@dkotter dkotter requested a review from jeffpaul December 23, 2025 17:38
@dkotter dkotter self-assigned this Dec 23, 2025
@jeffpaul jeffpaul added this to the 0.2.0 milestone Dec 23, 2025
@jeffpaul jeffpaul merged commit acfd96b into WordPress:develop Dec 23, 2025
37 of 39 checks passed
@dkotter dkotter deleted the fix/failing-plugin-check branch December 23, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants