[custom-descriptors] ref.cast_desc #7630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an optional `desc` child to `RefCast` for use in the new `ref.cast_desc` instruction. Add support for parsing, printing, and validating the new instruction. Fix a few minor issues left over from adding the branching descriptor casts along the way.
kripken
reviewed
May 28, 2025
| @@ -208,7 +208,7 @@ class IRBuilder : public UnifiedExpressionVisitor<IRBuilder, Result<>> { | |||
| bool isReturn, | |||
| std::optional<std::uint8_t> inline_ = std::nullopt); | |||
| Result<> makeRefTest(Type type); | |||
| Result<> makeRefCast(Type type); | |||
| Result<> makeRefCast(Type type, bool isDesc); | |||
There was a problem hiding this comment.
Do we use bools like that elsewhere?
There was a problem hiding this comment.
Oh wait, sorry, I was reading the wrong code for context. This looks ok.
kripken
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional
descchild toRefCastfor use in the newref.cast_descinstruction. Add support for parsing, printing, andvalidating the new instruction. Fix a few minor issues left over from
adding the branching descriptor casts along the way.