Fix assertion failure in type-refining-gufa #7612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`filterPackedDataReads` had an assertion that the read field existed, but it was possible for this to not be the case when the reference being read from was null. Avoid the assertion failure by checking for this case and filtering the read results to `none` because a read from null will never return.
kripken
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filterPackedDataReadshad an assertion that the read field existed,but it was possible for this to not be the case when the reference being
read from was null. Avoid the assertion failure by checking for this
case and filtering the read results to
nonebecause a read from nullwill never return.