-
Notifications
You must be signed in to change notification settings - Fork 786
Extend getMaxbits to handle Block type #7590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Current PR is to just implement the As discussed in #7559, should we bother to introduce the |
UPDATE: I've fuzzing for about three hour, and all is well. |
Since there is a need to extend the getMaxBits to handle the Block, could you please review this PR if you have a moment? @kripken |
Co-authored-by: Alon Zakai <alonzakai@gmail.com>
08c35cf
to
8b3f2c3
Compare
Co-authored-by: Alon Zakai <alonzakai@gmail.com>
I've also fuzzing for 3 hours; and all is well. |
Co-authored-by: Alon Zakai <alonzakai@gmail.com>
There is a need to extend the getMaxBits to handle the
Block
.For example, wasm-opt (95808a7) cannot optimize the following code snippet
to zero, the root cause is that
getMaxBits
fails to deal with the block.Fixes: #7559