Skip to content

Implement type imports and exports #7330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Implement type imports and exports #7330

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c066fcd
Type imports
vouillon Feb 24, 2025
48cc48e
Add tests
vouillon Feb 25, 2025
9e527ef
Test updates
vouillon Feb 26, 2025
7e56d35
More test updates
vouillon Feb 26, 2025
df60079
Fix hashing and comparison
vouillon Feb 27, 2025
f098ced
Fuzzing updates
vouillon Feb 27, 2025
fce76ff
Validation fixes
vouillon Feb 27, 2025
e316807
Reuse the type-sorting code from ModuleUtils in wasm-merge
vouillon Feb 27, 2025
982ab07
Comment updates
vouillon Feb 27, 2025
6dfcdb9
Tests: name functions
vouillon Feb 27, 2025
22e093b
Rename Import to TypeImport
vouillon Feb 27, 2025
60bd789
Unnecessary include
vouillon Feb 27, 2025
bc7c3f8
Fix Subtypes::getMaxDepths
vouillon Feb 27, 2025
1541147
Merge remote-tracking branch 'origin/main' into type-imports
vouillon Mar 13, 2025
7da566f
fix
vouillon Mar 13, 2025
c989d27
Put type exports with other exports
vouillon Feb 27, 2025
ad45a6d
Fix tool options
vouillon Mar 14, 2025
aa1e4ae
format
vouillon Mar 14, 2025
682ab0f
Fix tool outputs
vouillon Mar 14, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format
  • Loading branch information
@vouillon
vouillon committed Mar 14, 2025
commit aa1e4aeb23816aeafae9059d2159a96e01a2a5c8
42 changes: 21 additions & 21 deletions src/wasm/wasm-binary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ void WasmBinaryWriter::writeExports() {
case ExternalKind::Tag:
o << U32LEB(getTagIndex(*curr->getInternalName()));
break;
case ExternalKind::Type:
case ExternalKind::Type:
writeHeapType(*curr->getHeapType());
break;
default:
Expand Down Expand Up @@ -4459,26 +4459,26 @@ void WasmBinaryReader::readExports() {
ExternalKind kind = (ExternalKind)getU32LEB();
std::variant<Name, HeapType> value;
switch (kind) {
case ExternalKind::Function:
value = getFunctionName(getU32LEB());
break;
case ExternalKind::Table:
value = getTableName(getU32LEB());
break;
case ExternalKind::Memory:
value = getMemoryName(getU32LEB());
break;
case ExternalKind::Global:
value = getGlobalName(getU32LEB());
break;
case ExternalKind::Tag:
value = getTagName(getU32LEB());
break;
case ExternalKind::Type:
value = getHeapType();
break;
case ExternalKind::Invalid:
throwError("invalid export kind");
case ExternalKind::Function:
value = getFunctionName(getU32LEB());
break;
case ExternalKind::Table:
value = getTableName(getU32LEB());
break;
case ExternalKind::Memory:
value = getMemoryName(getU32LEB());
break;
case ExternalKind::Global:
value = getGlobalName(getU32LEB());
break;
case ExternalKind::Tag:
value = getTagName(getU32LEB());
break;
case ExternalKind::Type:
value = getHeapType();
break;
case ExternalKind::Invalid:
throwError("invalid export kind");
}
wasm.addExport(new Export(name, kind, value));
}
Expand Down
Loading