-
Notifications
You must be signed in to change notification settings - Fork 786
Multi-Memory Only Wasm-Split #5362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8 tests are failing because updated imports/exports are missing. The changes in #5363 need to be submitted first. |
One emscripten wasm-split test is failing,
|
Codecov Report
@@ Coverage Diff @@
## main #5362 +/- ##
==========================================
- Coverage 42.46% 42.43% -0.04%
==========================================
Files 482 481 -1
Lines 74727 74663 -64
Branches 11929 11925 -4
==========================================
- Hits 31735 31685 -50
+ Misses 39786 39774 -12
+ Partials 3206 3204 -2
|
This PR removes the "global" and "in-memory" options from the wasm-split tool's instrumenter, leaving secondary memory as the only option for profile-data collection. After the instrumenter creates and uses the secondary memory, the multi-memory lowering pass will be run to lower the memories into a single combined memory.