Skip to content

Multi-Memory Only Wasm-Split #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Multi-Memory Only Wasm-Split #5362

wants to merge 15 commits into from

Conversation

ashleynh
Copy link
Collaborator

@ashleynh ashleynh commented Dec 18, 2022

This PR removes the "global" and "in-memory" options from the wasm-split tool's instrumenter, leaving secondary memory as the only option for profile-data collection. After the instrumenter creates and uses the secondary memory, the multi-memory lowering pass will be run to lower the memories into a single combined memory.

@ashleynh ashleynh changed the title Multi-Memory Exclusive Wasm-Split Dec 19, 2022
@ashleynh ashleynh changed the base branch from main to memexports December 19, 2022 02:48
@ashleynh ashleynh changed the base branch from memexports to main December 31, 2022 04:37
@ashleynh
Copy link
Collaborator Author

ashleynh commented Dec 31, 2022

8 tests are failing because updated imports/exports are missing. The changes in #5363 need to be submitted first.

@ashleynh
Copy link
Collaborator Author

ashleynh commented Jan 2, 2023

One emscripten wasm-split test is failing, other.test_split_main_module:

failed to asynchronously prepare wasm: LinkError: WebAssembly.instantiate(): memory import 14 is smaller than initial 257, got 256

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #5362 (00b77e8) into main (c37bda1) will decrease coverage by 0.04%.
The diff coverage is 98.30%.

@@            Coverage Diff             @@
##             main    #5362      +/-   ##
==========================================
- Coverage   42.46%   42.43%   -0.04%     
==========================================
  Files         482      481       -1     
  Lines       74727    74663      -64     
  Branches    11929    11925       -4     
==========================================
- Hits        31735    31685      -50     
+ Misses      39786    39774      -12     
+ Partials     3206     3204       -2     
Files Changed Coverage Δ
src/tools/wasm-split/split-options.cpp 80.71% <ø> (-1.48%) ⬇️
src/tools/wasm-split/instrumenter.cpp 98.82% <98.24%> (+3.26%) ⬆️
src/tools/wasm-split/wasm-split.cpp 77.57% <100.00%> (-0.59%) ⬇️

... and 6 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant