Skip to content

wasm-emscripten-finalize: Allow optional running of memory-packing #5042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

wasm-emscripten-finalize: Allow optional running of memory-packing #5042

wants to merge 1 commit into from

Conversation

sbc100
Copy link
Member

@sbc100 sbc100 commented Sep 15, 2022

No description provided.

@sbc100
wasm-emscripten-finalize: Allow optional running of memory-packing
86678ef 
This would normally run during wasm-opt but when we write out the
memory file during wasm-emscripten-finalize we loose the ability to
run this later.

Ideally the writing out of the memory file would be delayed until after
finalize has been run but that is a bigger change.
@sbc100 sbc100 requested a review from dschuff September 15, 2022 10:43
@sbc100 sbc100 force-pushed the finalize_memory_packing branch from ccd9f50 to 86678ef Compare September 15, 2022 10:44
@dschuff
Copy link
Member

dschuff commented Mar 10, 2023

(sorry for the necromancy, just clearing out my inbox here...)
Do we still want to do this? we are mostly transitioning away from using wasm-emscripten-finalize where possible.
@sbc100
Copy link
Member Author

sbc100 commented Mar 10, 2023

I can't remember why I wanted this feature :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@sbc100 @dschuff