Run auto-update script on CI to check for uncommited changes #4538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Mar 21, 2022
aheejin
approved these changes
Mar 21, 2022
|
|
||
| - name: verify auto-updating causes no changes | ||
| run: ./auto_update_tests.py lit | git diff test/ | ||
| if: matrix.os == 'ubuntu-latest' |
There was a problem hiding this comment.
This is to prevent it from trying to run on windows, I think. We have the same for other similar scripts.
Co-authored-by: Thomas Lively <7121787+tlively@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would have caught #4534 early.
This just runs the
littests atm. Those are the ones we update the mostso I think it has the most value, and it's a fast suite since it's parallel.
Running all the suites would give more coverage, but would almost
double our build times which I'm not sure is worth it.