Skip to content

wasm-reduce: Do not verify binary roundtripping when not using binary files #3590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kripken
Copy link
Member

@kripken kripken commented Feb 19, 2021

A reduction on text files may be done on text because binary writing is
where the bug is.

Diff is 99% whitespace.

Copy link
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't try roundtripping to binary sounds right to me when not using binary, but I'm not sure what "binary writing is where the bug is" means..?

@kripken
Copy link
Member Author

kripken commented Feb 19, 2021

Sorry, by "binary writing is where the bug is" I meant that I had a bug in binary writing. I ran the reducer on text to get a testcase for it, so the testcase was "write the binary and check for a crash". That's when I noticed the issue here.

@kripken
Copy link
Member Author

kripken commented Feb 25, 2021

Actually I changed my mind here. I think it is good to verify that reading and writing the input works even when not reducing on binary. But the comments were confusing, which is why I was mixed up before. I fixed those now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants