Skip to content

expand allowed types for tableRefFor and tableNameFor #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2023
Merged

expand allowed types for tableRefFor and tableNameFor #2408

merged 1 commit into from
May 19, 2023

Conversation

@falkenhawk
Copy link
Contributor

@falkenhawk falkenhawk commented Apr 22, 2023

ported from ovos#9

It fixes:

TS2345: Argument of type 'ModelClass<any>' is not assignable to parameter of type 'typeof Model'.

for cases like:

query.tableRefFor(query.modelClass());
@falkenhawk falkenhawk mentioned this pull request Apr 22, 2023
Closed
@marcinlee @falkenhawk
expand allowed types for tableRefFor and tableNameFor
315535d 
it fixes:
Argument of type 'ModelClass<Foo>' is not assignable to parameter of type 'typeof Model'
@falkenhawk falkenhawk force-pushed the v3-mod-model-type-fix branch from 7eafc42 to 315535d Compare April 26, 2023 15:06
@lehni
Copy link
Collaborator

lehni commented May 19, 2023

LGTM, thanks!
@lehni lehni merged commit fed87de into Vincit:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@falkenhawk @lehni @marcinlee