Skip to content

fix: jsonSchemaWithoutRequired doesn't handle empty definitions #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix: jsonSchemaWithoutRequired doesn't handle empty definitions #2183

merged 1 commit into from
Jun 30, 2023

Conversation

@thejuan
Copy link
Contributor

@thejuan thejuan commented Jan 3, 2022

A schema with an empty definitions object causes jsonSchemaWithoutRequired to throw

 TypeError: Cannot convert undefined or null to object
      at Function.assign (<anonymous>)
      at jsonSchemaWithoutRequired (lib/model/AjvValidator.js:262:20)
      at AjvValidator.compilePatchValidator (lib/model/AjvValidator.js:136:18)
      at AjvValidator.getValidator (lib/model/AjvValidator.js:120:26)
@lehni lehni merged commit d56e4c7 into Vincit:master Jun 30, 2023
@lehni
Copy link
Collaborator

lehni commented Jul 20, 2023

Released in v3.0.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@thejuan @lehni