-
Notifications
You must be signed in to change notification settings - Fork 117
Add multiple AI providers #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@codegirl-007 make pr_ready |
|
I am on a phone and it feels impossible to review this. I'll have to wait until the morning |
|
Did you add cursor cli? |
Yeah, It should be good soon.
Yeah, don't do that to yourself.
Yes. |
My free credits thank you |
|
Something is wrong with your stylus :( Also any tests? |
|
I can write the tests if you don't. It's not really that interesting, since the current one runs, it likely works |
I'll add tests. No worries. |
- Add ClaudeCodeProvider and CursorAgentProvider - Refactor providers to use BaseProvider for shared logic - Each provider only implements _build_command() and _get_provider_name()
|
woops. I'm a noob. Didn't mean to close this pr. I fixed it. |
| end | ||
| end | ||
|
|
||
| --- @class BaseProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codegirl-007 typically i prefer _99. fro type name. ill change this, dont worry
| logger:debug("stdout#error", "err", err) | ||
| end | ||
| if not err and data then | ||
| table.insert(response_data, data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we holding onto response data?
| local command = self:_build_command(query, request) | ||
| logger:debug("make_request", "command", command) | ||
|
|
||
| local response_data = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ill remove this too, dont worry about it :)
|
merging this in loser |
To change providers in config, you'd use one of these:
Example