refactor(query-core): extract context creation to functions and move type assertions #9210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 18ab57f.
☁️ Nx Cloud last updated this comment at |
braden-w
force-pushed
the
refactor/better-type-assertion
branch
from
3bfd135 to
013e231
Compare
Codecov ReportAll modified and coverable lines are covered by tests ���
Additional details and impacted files@@ Coverage Diff @@
## main #9210 +/- ##
===========================================
+ Coverage 45.24% 59.63% +14.39%
===========================================
Files 209 138 -71
Lines 8247 5495 -2752
Branches 1860 1473 -387
===========================================
- Hits 3731 3277 -454
+ Misses 4076 1921 -2155
+ Partials 440 297 -143 🚀 New features to boost your workflow:
|
…type assertions This refactor extracts the creation of the query function context and fetch context into dedicated helper functions (e.g., `createQueryFnContext`), improving code readability. This change: - Moves type assertions and type handling higher up, reducing inline type noise and making type boundaries clearer. - Replaces ad-hoc object construction with a function that does one thing (build query contexts). No functional behavior is changed; this is a structural and type-safety improvement.
braden-w
force-pushed
the
refactor/better-type-assertion
branch
from
013e231 to
18ab57f
Compare
TkDodo
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor extracts the creation of the query function context and fetch context into dedicated helper functions (e.g.,
createQueryFnContext), improving code readability. This change:No functional behavior is changed; this is a structural and type-safety improvement.