feat(react-query): add mutationOptions #8960
Conversation
github-actions
bot
added
documentation
Ubinquitous
force-pushed
the
feature/react-query-mutation-options
branch
from
5e14207 to
596896d
Compare
|
View your CI Pipeline Execution ↗ for commit f3b74c0.
☁️ Nx Cloud last updated this comment at |
| TData, | ||
| TMutationKey | ||
| >['mutationFn'], | ||
| SkipToken | undefined |
There was a problem hiding this comment.
skipToken is specific to queries. This isn’t needed.
| UseMutationOptions<TMutationFnData, TError, TData, TMutationKey>, | ||
| 'mutationFn' | ||
| > & { | ||
| initialData: |
There was a problem hiding this comment.
there is no initialData for mutations
| TMutationKey | ||
| >, | ||
| ): DefinedInitialDataOptions<TMutationFnData, TError, TData, TMutationKey> & { | ||
| mutationKey: DataTag<TMutationKey, TMutationFnData, TError> |
There was a problem hiding this comment.
we also don’t need a DataTag, this is query specific.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8960 +/- ##
===========================================
+ Coverage 44.60% 84.30% +39.70%
===========================================
Files 203 27 -176
Lines 8107 376 -7731
Branches 1815 110 -1705
===========================================
- Hits 3616 317 -3299
+ Misses 4059 50 -4009
+ Partials 432 9 -423
🚀 New features to boost your workflow:
|
|
Thank you for reviewing my PR. I thought queryOptions and mutationOptions could be structured similarly since it was an options-related function. I re-created useMutation as start. I changed it to only have UseMutationOptions, excluding unnecessary data tags and initialData. |
| options: UseMutationOptions<TData, TError, TVariables, TContext>, | ||
| ): UseMutationOptions<TData, TError, TVariables, TContext> | ||
|
|
||
| export function mutationOptions(options: unknown) { |
There was a problem hiding this comment.
if there’s only declaration, we don’t need overloads
There was a problem hiding this comment.
Thank you, I changed it to a non-overloaded function.
|
I merged #9094 to resolve below ci failure because of flaky timer tests 
|
mutationOptions helps extracting mutation options into separate functions.