Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 11 commits
- 112 files changed
- 9 contributors
Commits on Jun 2, 2025
-
refactor(types): narrow onSuccess/onError/onMutate/onSettled callback…
… types to Promise<void> | void (#9202) * refactor: narrow onSuccess/onError/onMutate/onSettled callback types to Promise<void> | void Previously, the `onSuccess`, `onError`, `onMutate`, and `onSettled` callbacks were typed as `() => Promise<unknown> | unknown`. While `unknown` is technically valid, it implies that the return value might be used, assigned, or further processed. However, throughout the codebase, these callbacks are invoked solely for their side effects, and their return values are always ignored. Narrowing the type to `Promise<void> | void` makes this intent explicit, clarifies that any return value will be discarded, and prevents misleading type signatures that suggest otherwise. This commit narrows their types to `() => Promise<void> | void`, which more accurately reflects their intended use. * docs: update callback return types to Promise<void> | void in mutation-related documentation This commit refines the documentation for mutation-related callbacks (`onSuccess`, `onError`, `onSettled`, and `onMutate`), changing their return types from `Promise<unknown> | unknown` to `Promise<void> | void`.
-
docs: Mention query keys needs to be serializable using `JSON.stringi…
…fy` (#9204) This was not clear to me and so maybe a useful addition to the docs
-
-
refactor(query-core): extract context creation to functions and move …
…type assertions (#9210) This refactor extracts the creation of the query function context and fetch context into dedicated helper functions (e.g., `createQueryFnContext`), improving code readability. This change: - Moves type assertions and type handling higher up, reducing inline type noise and making type boundaries clearer. - Replaces ad-hoc object construction with a function that does one thing (build query contexts). No functional behavior is changed; this is a structural and type-safety improvement.
-
-
feat(query-devtools): add indicator for staleTime: "static" (#9215)
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
-
chore: improve type safety in
getQueryDataby using generics (#9218)Refactored the `getQueryData` method in `QueryClient` to use generics for type inference instead of type assertion with `as`. The previous implementation of `getQueryData` relied on a type assertion (`as`) to cast the result of `queryCache.get()`: ```typescript return this.#queryCache.get(options.queryHash)?.state.data as | TInferredQueryFnData | undefined ``` While this works, using generics is a more type-safe and idiomatic approach in TypeScript. It allows the type system to infer the correct type for `TInferredQueryFnData` when `queryCache.get` is called, reducing the need for manual type casting and potential runtime errors if the cast is incorrect. ## Changes The `getQueryData` method has been updated to pass `TInferredQueryFnData` as a generic type argument to `this.#queryCache.get()`: **Before:** ```typescript return this.#queryCache.get(options.queryHash)?.state.data as | TInferredQueryFnData | undefined ``` **After:** ```typescript return this.#queryCache.get<TInferredQueryFnData>(options.queryHash)?.state .data ``` This change leverages the existing generic type parameter `TInferredQueryFnData` already defined in the `getQueryData` signature and `QueryCache#get` method. -
chore: remove redundant word in comment (#9231)
Signed-off-by: clonemycode <clonecode@aliyun.com> Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com>
-
refactor(types): remove unnecessary TQueryData generic in InfiniteQue…
…ryObserverOptions (#9224) * refactor(core): remove unnecessary TQueryData in InfiniteQueryObserverOptions * refactor(react-query,solid-query,svelte-query,vue-query,angular-query): remove unnecessary TQueryData in InfiniteQueryObserverOptions * ci: apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
3 people authoredJun 2, 2025
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main@{1day}...main