Sync changes with pcl conversions, message filter, nav2 #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
SteveMacenski
approved these changes
Jul 3, 2025
Owner
|
Whoops, I didn't think about updating this and https://github.com/SteveMacenski/nonpersistent_voxel_layer when I made that refactor |
Contributor
Author
I have stvl + nav2 in my workspace, so I noticed this when I pulled in the latest changes of nav2, I can update non persistent voxel layer as well if no one is on it :) |
Owner
|
I don't think anyone's on it yet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr sync changes with pcl conversions, message filter, nav2
For pcl_conversions: my last pr #329 is not working properly with the latest release of pcl conversions, it will reported xxx.h not found when compiling, it works with the older release though, I am not entirely sure why
For message filters: mostly the SubscriberBase part
For nav2: related to ros-navigation/navigation2#5288