Generate lockfile for using setuptools #5840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
requested review from
a team,
amanda11,
arm4b,
nzlosh,
rush-skills and
winem
pull-request-size
bot
added
the
size/L
Eric-Arellano
approved these changes
Dec 7, 2022
pants uses setuptools when building wheels and similar packaging tasks
cognifloyd
force-pushed
the
pants-setuptools
branch
from
ec46508 to
2c4dddd
Compare
nzlosh
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is another part of introducing pants, as discussed in various TSC meetings.
Related PRs can be found in:
Overview of this PR
This configures pants and generates a lockfile so it can use
setuptoolswhen running thepackagegoal, which includes building wheels.We will still need more config before we can use pants to build wheels, but this is a prerequisite for that. To build wheels, we also need to add metadata to BUILD files. To simplify the metadata that has to be repeated for each wheel future PRs will include at least: a pants macro and a pants plugin.
Here is the
pants.tomlconfig this PR adds:st2/pants.toml
Lines 150 to 153 in ec46508
Note: Many other resolves also include setuptools. This resolve is for when pants has to call setuptools directly, not for when it is used indirectly.
setuptools version
I added a range of versions that we can use. I tried using newer versions, but they didn't work with python 3.6, so I capped that.
lockfiles/setuptools.lock
At 120 lines this is the smallest lockfile we have.