add ST2_USE_DEBUGGER env var to mirror --use-debugger arg #5675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
Contributor
|
For the record. Monkey patching sockets is not something I would allow in
production code . But that hill has already been climbed in this case
…On Mon, Jul 18, 2022 at 3:07 PM Jacob Floyd ***@***.***> wrote:
Extracted the st2-specific bits from #5674
<#5674>.
This allows setting ST2_USE_DEBUGGER as an env var instead of passing
--use-debugger as a command line arg. An env var is more convenient in
some cases, such as when using containerized/docker st2.
------------------------------
You can view, comment on, or merge this pull request online at:
#5675
Commit Summary
- d4d9a1f
<d4d9a1f>
add ST2_USE_DEBUGGER env var to mirror --use-debugger arg
File Changes
(2 files <https://github.com/StackStorm/st2/pull/5675/files>)
- *M* CHANGELOG.rst
<https://github.com/StackStorm/st2/pull/5675/files#diff-2c623f3c6a917be56c59d43279244996836262cb1e12d9d0786c9c49eef6b43c>
(3)
- *M* st2common/st2common/util/monkey_patch.py
<https://github.com/StackStorm/st2/pull/5675/files#diff-a9d1208b198addd761599450ce7fdddc94c2433cdb3d3ab08a6507d3bd0b6add>
(6)
Patch Links:
- https://github.com/StackStorm/st2/pull/5675.patch
- https://github.com/StackStorm/st2/pull/5675.diff
—
Reply to this email directly, view it on GitHub
<#5675>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZ5TIONYJKC4AWNXFDBQEDVUWTN3ANCNFSM535JGNYQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
rush-skills
approved these changes
Jul 19, 2022
amanda11
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted the st2-specific bits from #5674.
This allows setting
ST2_USE_DEBUGGERas an env var instead of passing--use-debuggeras a command line arg. An env var is more convenient in some cases, such as when using containerized/docker st2.