Skip to content

Fix build failures due to newer MarkUpSafe #5581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arm4b merged 7 commits into from
Feb 28, 2022
Merged

Fix build failures due to newer MarkUpSafe #5581

arm4b merged 7 commits into from
Feb 28, 2022

Conversation

@amanda11
Copy link
Contributor

@amanda11 amanda11 commented Feb 28, 2022 •
edited
Loading

Fix build errors due to markupsafe 2.1.0 removing soft_unicode, which were breaking the ST2 package tests.

Also, updated the GHA workflow as problems found after requirements.txt was altered. Altered so that it only looks for a cache on exact match of key instead of partial, so that doesn't try and pick up cache from previous version of requirements.txt.
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Feb 28, 2022
@amanda11 amanda11 added this to the 3.7.0 milestone Feb 28, 2022
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines. Good size to review. and removed size/S PR that changes 10-29 lines. Very easy to review. labels Feb 28, 2022
@amanda11 amanda11 changed the title [WIP] Fix build failures due to newer MarkUpSafe Feb 28, 2022
arm4b
arm4b approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🍏
@arm4b arm4b merged commit 7f36599 into master Feb 28, 2022
@arm4b arm4b deleted the fix_markup_safe branch February 28, 2022 19:28
@cognifloyd cognifloyd mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix size/M PR that changes 30-99 lines. Good size to review.

3 participants

@amanda11 @arm4b