Change minimum garbage_collection TTL to 1 day from 7 #5287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pull-request-size
bot
added
the
size/XS
arm4b
suggested changes
Jun 15, 2021
Member
There was a problem hiding this comment.
Thanks for finding this setting and for the contribution @ericreeves ! 👍
We'll just need a CHANGELOG record for this and CLA signed based on Github bot message above.
Besides that, all good.
As for the current 3.5.0 we got code freeze already from the release team, the change will be included in the next release.
arm4b
reviewed
Jun 16, 2021
Kami
approved these changes
Jul 4, 2021
Member
Kami
left a comment
Kami
left a comment
There was a problem hiding this comment.
Yeah that change seems reasonable to me 👍
pull-request-size
bot
added
size/S
pull-request-size
bot
added
size/XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very simple change to modify the minimum TTL on the garbage collector, pulling it back to 1 day from 7.
It still seems quite reasonable to ensure the user doesn't specify "0".