Use io.open() when running on Python 2 #5107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
Contributor
Author
|
See the Ansible pack CI for illuminating this regression. That issue will affect all Python 2 pack CI runs, which will be ~160 starting later today. |
arm4b
approved these changes
Dec 18, 2020
Contributor
Author
|
Thanks for the review! Will merge this later today once all of the CI (except for maybe Travis) are green. |
nmaludy
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced by #5106. That code runs within a pack's virtualenv, and because we are still supporting Python 2 in StackStorm Exchange packs, we also need to support Python 2 in
st2common/content/loader.py.Using the
encodingkeyword argument toopen()works on Python 3, but the nativeopen()on Python 2 does not accept theencodingargument.Instead, this PR imports
io.openwhen running on Python 2, which should resolve the issue.Thanks to @nmaludy for tracking down the issue and @armab for pointing this Stack Overflow post out on Slack.