Remove authentication headers from webhook payloads #4983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Krisztian Nagy <krisztian.nagy@emarsys.com>
pull-request-size
bot
added
the
size/S
|
|
arm4b
reviewed
Jul 2, 2020
arm4b
reviewed
Jul 2, 2020
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Thanks for contributing this. The change looks great!
Please also include a Changelog record for this in CHANGELOG.rst.
Co-authored-by: Eugen C. <armab@users.noreply.github.com>
Co-authored-by: Krisztian Nagy <krisztian.nagy@emarsys.com>
pull-request-size
bot
added
size/M
Contributor
Author
|
updated the |
arm4b
reviewed
Jul 2, 2020
nmaludy
suggested changes
Sep 29, 2020
Member
nmaludy
left a comment
nmaludy
left a comment
There was a problem hiding this comment.
I like this idea a lot. Probably good to list out what headers are going to be stripped out in the CHANGELOG and probably also in st2docs
nmaludy
approved these changes
Sep 29, 2020
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authentication headers (along with authentication cookies) shouldn't be stored in the payload of the trigger instance, since authentication data from
GETquery parameters are not stored either.Not filtering in
_log_requestsince onDEBUGloglevel those can be useful data.