-
-
Notifications
You must be signed in to change notification settings - Fork 779
Update dig.py error handling #4732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…led. Update readme. Bump pack version.
…led. Update readme. Bump pack version.
…ded a NOTE to revisit once py3 only.
|
@blag updated based on your requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will wait for @blag for his review,
but a small nitpick from me: I think this improvement will also need a CHANGELOG record since it's part of st2 core.
blag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small wording change, and add a changelog please.
Other than that, this looks good to go! 👍
|
Thanks for the contribution! |
I have added an exception to the linux.dig action script to handle the situation where the
digcommand is not installed, which, it seems on CentOS/RHEL gets the user this error:This doesn't seem to be an issue on Ubuntu. It appears the
dnsutilsis installed. At least on the vagrant st2 dev environment. As you can see there is now a better error message if we get anOSErrorexception, suggesting that dig is either not on the PATH or installed.I have also update the linux pack readme to include the dig action.
Since this is a core pack and installed by default, I opened the below PR to install bind-utils by default in EL7 distros.
StackStorm/st2-packages#619