Refactor HuggingFace model initialization to include base model name … #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and update tokenizer logic
recursix
reviewed
Dec 19, 2024
| if base_model_name is None: | ||
| self.tokenizer = AutoTokenizer.from_pretrained(model_name) | ||
| else: | ||
| self.tokenizer = AutoTokenizer.from_pretrained(base_model_name) |
Collaborator
There was a problem hiding this comment.
I don't get what's the point of that...
Collaborator
Author
There was a problem hiding this comment.
yes, sorry a little cryptic. I made this to support LoRA checkpoints, which are stored in the model_name directory. They are applied to a base model, stored at base_model_name directory. The directory where the adapters are stored contains only the adapters, while the model's safetensors + tokenizers, etc. are located in base_model_name
recursix
approved these changes
Dec 20, 2024
ludunjie1219
pushed a commit
to agenttrek/AgentLab
that referenced
this pull request
Dec 29, 2024
…and update tokenizer logic (ServiceNow#190)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and update tokenizer logic