You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build commands use absolute paths like 'py/docs/requirements.txt' and 'py/requirements.txt'. Verify these paths are correct relative to where RTD executes the commands, as path resolution might differ in the RTD environment.
The build commands are using absolute paths that might cause issues in the Read the Docs environment. The paths should be relative to the configuration file location to ensure proper execution.
Why: The suggestion correctly identifies a potential issue with absolute paths in the build commands. Using relative paths instead of absolute paths is more maintainable and less error-prone in the Read the Docs environment, especially since the configuration file has been moved to a subdirectory.
The build commands are using absolute paths that might cause issues in the ReadTheDocs environment. The paths should be relative to the repository root, but the configuration file is now in a subdirectory. Consider using environment variables or adjusting paths to ensure they're correctly resolved.
Why: The suggestion correctly identifies a critical issue with path references in the ReadTheDocs configuration. Since the file has been moved to a subdirectory, the absolute paths would fail to resolve correctly, potentially breaking the documentation build process.
Medium
General
✅ Fix grammatical errorsSuggestion Impact:The commit implemented exactly the grammatical correction suggested, adding the missing 'be' in 'should be staged again' for both the black and isort instructions
code diff:
- - `black` will rewrite the violations automatically, however the files are unstaged and should staged again- - `isort` will rewrite the violations automatically, however the files are unstaged and should staged again+ - `black` will rewrite the violations automatically, however the files are unstaged and should be staged again+ - `isort` will rewrite the violations automatically, however the files are unstaged and should be staged again
There's a grammatical error in the instructions about staging files after running black and isort. The phrase "should staged again" is incorrect and could confuse contributors.
- `flake8` requires manual fixes
-- `black` will rewrite the violations automatically, however the files are unstaged and should staged again-- `isort` will rewrite the violations automatically, however the files are unstaged and should staged again+- `black` will rewrite the violations automatically, however the files are unstaged and should be staged again+- `isort` will rewrite the violations automatically, however the files are unstaged and should be staged again
[Suggestion has been applied]
Suggestion importance[1-10]: 5
__
Why: The suggestion correctly identifies and fixes a grammatical error in the contributing instructions, changing "should staged again" to "should be staged again". While not affecting functionality, this improves clarity and professionalism of the documentation.
✅ Use specific Python versionSuggestion Impact:The commit directly implemented the suggestion by changing the Python version from 'latest' to '3.11' in the .readthedocs.yaml file
code diff:
- python: "latest"+ python: "3.11"
Using "latest" for Python version can lead to unexpected build failures when new Python versions are released. Specify a concrete Python version (like "3.11") to ensure build stability and reproducibility.
Why: Using a specific Python version instead of "latest" is a good practice for build stability and reproducibility. This change would prevent potential issues when new Python versions are released that might introduce compatibility problems.
✅ Add PYTHONPATH to sphinx-buildSuggestion Impact:The commit implemented exactly what was suggested - adding the PYTHONPATH=py environment variable to the sphinx-build command to prevent potential import errors during documentation building
code diff:
- - sphinx-build -b html -d build/docs/doctrees py/docs/source $READTHEDOCS_OUTPUT/html+ - PYTHONPATH=py sphinx-build -b html -d build/docs/doctrees py/docs/source $READTHEDOCS_OUTPUT/html
The PYTHONPATH environment variable is set only for the sphinx-autogen command but not for the sphinx-build command. This could lead to import errors during documentation building if the Python modules need to be imported from the py directory.
Why: This suggestion addresses a potential build failure issue. Setting PYTHONPATH for sphinx-autogen but not for sphinx-build could cause import errors during documentation generation since sphinx-build also needs to access Python modules in the py directory.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
💥 What does this PR do?
supersedes #15611
This PR fixes the publishing of the Python API docs at readthedocs.com. This has been broken since Selenium version 4.14.
The docs get published with every commit to selenium trunk (I think). The job is configured at: https://app.readthedocs.org/projects/selenium-python-api-docs (this account is managed by @diemol)
Once the job runs, docs are published to: https://selenium-python-api-docs.readthedocs.io
I tested this configuration from my own account at readthedocs.com pointing to my fork of the selenium repo, and it worked fine.
Note: I don't think the readthedocs job is configured to build Pull Requests, so this won't be triggered until it lands in trunk.
PR Type
Bug fix, Documentation
Description
Updated Read the Docs configuration for Python API documentation.
Moved
.readthedocs.yaml
topy/docs
directory.Enhanced Python API documentation with updated links and structure.
Added support for newer Python versions and updated build tools.
Changes walkthrough 📝
.readthedocs.yaml
Removed outdated Read the Docs configuration.
.readthedocs.yaml
.readthedocs.yaml
Added updated Read the Docs configuration file.
py/docs/.readthedocs.yaml
index.rst
Enhanced Python API documentation content.
py/docs/source/index.rst