Skip to content

Use Node 18 #12724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2023
Merged

Use Node 18 #12724

merged 1 commit into from
Dec 21, 2023

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Sep 11, 2023 •
edited
Loading

part of #12723

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Upgrading the 2 places where I found a version of Node ad use the latest LTS

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@CLAassistant
Copy link

CLAassistant commented Sep 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
@apupier apupier force-pushed the 12723-useNode18 branch 2 times, most recently from 29de50f to 3e97524 Compare September 11, 2023 15:22
@diemol
Copy link
Member

diemol commented Sep 17, 2023

@apupier let us know when this can be reviewed and merged, it is marked as draft.
@apupier
Use Node 18
02058f7 
Use 18.17.0 in WORKSPACE file as it is the latest version supported by
bazelbuild/rules_nodejs 5.8.4 which is the latest 5.x version.

part of SeleniumHQ#12723

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier
Copy link
Contributor Author

apupier commented Dec 21, 2023

sorry for the delay due to priority changes and there was no tests passing on my fork.

I rebased.
Most tests are passing, only two are failing on Firefox but it is also failing on trunk:
https://github.com/apupier/selenium/actions/runs/7286577804
https://github.com/apupier/selenium/actions/runs/7286285471

1) [firefox] Browsing Context can take box screenshot
  Message:
    InvalidArgumentError thrown
  Stack:
    error properties: Object({ remoteStacktrace: '' })
        at BrowsingContext.checkErrorInScreenshot (javascript/node/selenium-webdriver/bidi/browsingContext.js:234:17)
        at BrowsingContext.captureBoxScreenshot (javascript/node/selenium-webdriver/bidi/browsingContext.js:199:10)
        at processTicksAndRejections (node:internal/process/task_queues:95:5)
        at UserContext.<anonymous> (javascript/node/selenium-webdriver/test/bidi/bidi_test.js:464:26)

2) [firefox] WebDriver.actions() can move to and click element in an iframe
  Message:
    TimeoutError: Waiting for title to be "Submitted Successfully!"
    Wait timed out after 10109ms
  Stack:
    error properties: Object({ remoteStacktrace: '' })
        at javascript/node/selenium-webdriver/lib/webdriver.js:929:17
        at processTicksAndRejections (node:internal/process/task_queues:95:5)
@apupier apupier marked this pull request as ready for review December 21, 2023 10:51
diemol
diemol approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @apupier!
@diemol diemol merged commit 10561bc into SeleniumHQ:trunk Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@apupier @CLAassistant @diemol @AutomatedTester
close