Skip to content

docs: use Browser constants for browser name #10567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2022
Merged

docs: use Browser constants for browser name #10567

merged 1 commit into from
Apr 20, 2022

Conversation

Meir017
Copy link
Contributor

@Meir017 Meir017 commented Apr 20, 2022

Cleanup the nodejs bindings

Description

Cleanup the browser name usage in the readme of

Motivation and Context

This is a better approach that can avoid typo errors

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@CLAassistant
Copy link

CLAassistant commented Apr 20, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
diemol
diemol approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Meir017
@diemol diemol merged commit fbef19e into SeleniumHQ:trunk Apr 20, 2022
@diemol
Copy link
Member

diemol commented Apr 20, 2022

Oh, I missed that you did not sign the CLA. Could you please do that anyway? Thank you.
@Meir017
Copy link
Contributor Author

Meir017 commented Apr 20, 2022

@diemol oops, I have signed the cla in the past, I guess it has changed and needed to be signed again
@Meir017 Meir017 deleted the docs/nodejs-readme branch April 20, 2022 15:59
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
@Meir017 @elgatov
docs: use Browser constants for browser name (SeleniumHQ#10567)
bb9521a 
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@Meir017 @CLAassistant @diemol