Use class' class loader when looking up CDP implementations. #10509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, `CdpVersionFinder` was using `ServiceLoader.load` without passing in a class loader explicitly to find CDP implementations. In this case, `ServiceLoader` is using the current thread's default class loader to resolve the specified class name's service. In projects with a plugin system, this can lead to problems, when selenium dependencies are part of a jar file that is not on the class path the application was started with. For these projects, using selenium results in a `ClassNotFoundException` when connecting to a remote webdriver. To fix this, using the class loader of the class itself would be beneficial. In projects without a plugin architecture, it will mostly be identical with the class loader of the current thread, in other cases there is a very high chance that the service which is to be loaded can be resolved through the class loader of `CdpVersionFinder`.
dennisoelkers
changed the title
HttpClient factory.
|
Thank you @dennisoelkers! |
diemol
approved these changes
Apr 6, 2022
|
Kudos, SonarCloud Quality Gate passed! |
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
…umHQ#10509) Prior to this change, `CdpVersionFinder` was using `ServiceLoader.load` without passing in a class loader explicitly to find CDP implementations. In this case, `ServiceLoader` is using the current thread's default class loader to resolve the specified class name's service. In projects with a plugin system, this can lead to problems, when selenium dependencies are part of a jar file that is not on the class path the application was started with. For these projects, using selenium results in a `ClassNotFoundException` when connecting to a remote webdriver. To fix this, using the class loader of the class itself would be beneficial. In projects without a plugin architecture, it will mostly be identical with the class loader of the current thread, in other cases there is a very high chance that the service which is to be loaded can be resolved through the class loader of `CdpVersionFinder`. Co-authored-by: Puja Jagani <puja.jagani93@gmail.com> Co-authored-by: Diego Molina <diemol@users.noreply.github.com> [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Prior to this change,
CdpVersionFinderwas usingServiceLoader.loadwithout passing in a class loader explicitly to find CDP implementations. In this case,ServiceLoaderis using the current thread's default class loader to resolve the specified class name's service.In projects with a plugin system, this can lead to problems, when selenium dependencies are part of a jar file that is not on the class path the application was started with. For these projects, using selenium results in a
ClassNotFoundExceptionwhen connecting to a remote webdriver.To fix this, using the class loader of the class itself would be beneficial. In projects without a plugin architecture, it will mostly be
identical with the class loader of the current thread, in other cases there is a very high chance that the service which is to be loaded can be resolved through the class loader of
CdpVersionFinder.Types of changes
Checklist