[dotnet] Fix missing documentation comments in NuGet package #10376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Nobody? Easy fix. |
diemol
approved these changes
Apr 21, 2022
|
I think I am able to propose a fix for this, but building solution locally is a big pain. |
|
That's a shame. I wasn't able to make a proper build, maybe you'll have better luck. |
|
reopened the issue. I'm guessing it needs to be added to bazel somewhere in order to be included |
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
|
Maybe adding |
|
Everything, you know how to do it, does not work because of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All .nuspec files failed to include the XML files containing documentation comments. This regression was introduced with d77555a and affects v4.0.0, v4.0.1 and v4.1.0.
Fixes:
Both have been closed as duplicates of an unrelated bug (missing online documentation). Please consider reopening #10371 to track the underlying issue until this has been fixed. Both bugs do not mention online documentation, so I don't understand why they were closed.
Motivation and Context
Starting with version 4.0.0, all documentation comments were missing. This is because the XML file that contains those comments has been inadvertently excluded from the NuGet package.
Types of changes
Checklist
I was unable to test my changes because I was unable to complete a full build. Please consider improving your build instructions if you require such a complex build with this amount of dependencies.