Skip to content

[py] update ShadowRoot find element signatures to match those in WebElement #10138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

titusfortner
Copy link
Member

@AutomatedTester just making sure there wasn't a reason the signatures were different.

@codecov-commenter
Copy link

Codecov Report

Merging #10138 (89c9371) into trunk (eab9a52) will increase coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk   #10138   +/-   ##
=======================================
  Coverage   44.87%   44.88%           
=======================================
  Files          86       86           
  Lines        5658     5659    +1     
  Branches      264      264           
=======================================
+ Hits         2539     2540    +1     
  Misses       2855     2855           
  Partials      264      264           
Impacted Files Coverage Δ
py/selenium/webdriver/remote/shadowroot.py 16.00% <20.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab9a52...89c9371. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AutomatedTester
Copy link
Member

This is a zero value change. A more useful addition would be adding type hinting.

@AutomatedTester AutomatedTester merged commit 10fed03 into SeleniumHQ:trunk Dec 13, 2021
@diemol
Copy link
Member

diemol commented Dec 13, 2021

Why do we merge it if it is a zero value change?

@AutomatedTester
Copy link
Member

I will finish off the patch with the type hinting

@titusfortner
Copy link
Member Author

This is not a zero value change. It was literally a feature request from a user who wanted to have the same method wrapper for both methods and couldn't. I only PR'd it instead of merging it because I thought there might have been a reason you didn't just copy/paste what you already had.

If the WebElement methods had type hinting, I would have copied that over as well.

elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
@titusfortner titusfortner deleted the py_shadow branch December 4, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants