Skip to content

Conversation

@SFE-Brudnerd
Copy link
Owner

@SFE-Brudnerd SFE-Brudnerd commented Feb 26, 2024

Please only review my commits. I merged in other code from upstream that doesn't affect this. Please review the variant folder, the boards.txt, bootloader folder, libraries/BlockDevices/BlockDevice and **/**/QSPIBlockDevice, post_install.sh.

Thanks!

JAndrassy and others added 30 commits September 24, 2023 15:02
KeySlot was incorrectly encoded in a single byte.
As per https://github.com/NXPPlugNTrust/nano-package?tab=readme-ov-file#mbedtls-alt-files it should be stored over 4 bytes, in Big Endian order.
Fix: prevent artefacts from appearing on the screen during a SCROLL_LEFT.
Fixed hash algo to be selected based on input and not hardcoded
WiFiS3 fix Modem timeout at ERROR response
-Og provides "a reasonable level of optimization while maintaining fast compilation and a good debugging experience".
  - This library works only if WiFi firmware version is greater than 0.3.0
pennam and others added 23 commits February 14, 2024 17:00
OTAUpdate: do not use Error enum to return error codes
Add AES encrypt/decrypt and HMAC support for SE05X
Fix: do not randomly clear the first line of the LED matrix.
WiFiSSLClient: add setEccSlot method to configure client private key and certificate
…rt and setEccSlot

  - Also fix setCACert signature to be consistent with other core implementations
WiFiS3 let WiFi.h include WiFiClient, WiFiUDP, WiFiServer
WiFiS3 WiFiSSLClient: avoid duplicated AT messages
Update WIFI_FIRMWARE_LATEST_VERSION to 0.4.1
OTAUpdate: change root certificate to download binary from download.arduino.cc
@sfe-SparkFro
Copy link
Collaborator

Are you sure about these files? Seems like they got put in opposite folders.

image

Also, shouldn't the SD card power be enabled by default so a user can easily use it?

image

Otherwise seems fine to me!

@SFE-Brudnerd
Copy link
Owner Author

Yep, I unfortunately had to shoehorn their exclusion methods in a way that made sense. It uses the makefile exclude functionality, but they define files and then exclude directories based on those. I added the .portenta_exclude and .thingplus_exclude, .portenta_only already existed. It's mainly so I didn't have to do the same thing as them for every library in the repo.

While my intention was power savings by default, I see the argument about enabling it by default so that someone isn't confused. There would be more people confused if it was disabled by default. I'll make that change.

@SFE-Brudnerd SFE-Brudnerd merged commit ff95ff2 into main Mar 21, 2024
@SFE-Brudnerd SFE-Brudnerd deleted the dev branch March 21, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet