Skip to content

Fix CI errors #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
impervius wants to merge 5 commits into from
Closed

Fix CI errors #885

impervius wants to merge 5 commits into from

Conversation

@impervius
Copy link
Contributor

@impervius impervius commented Jul 11, 2025 •
edited
Loading

Depends on #884

  1. Run cargo clippy --fix.
  2. Run cargo fmt
  3. Remove unmaintained, wrong, partial and with broken links CHANGELOG.md. (it will be added again on release by the github action)
  4. Allow a deprecated function (until we find a good fix for it. The fix requires chromium or firefox, which might bloat the project and make it not that portable)
@impervius impervius marked this pull request as ready for review July 11, 2025 14:52
@impervius
Copy link
Contributor Author

impervius commented Jul 11, 2025

@devttys0 you did some of these, but note that you still have fmt warnings (as you ran fmt and then clippy, and not clippy and then fmt). Also points 3 and 4 above still need fixing. I might create another PR later to fix the CI failures.
@impervius impervius closed this Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@impervius