Skip to content

Register classes #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
demonpo wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Register classes #23

demonpo wants to merge 1 commit into from

Conversation

@demonpo
Copy link
Contributor

@demonpo demonpo commented Apr 6, 2020

Classes to store information about registers and interact with them

Signed-off-by: Daniel Garcia demonpogp@gmail.com
@demonpo
Copy link
Contributor Author

demonpo commented Apr 6, 2020

Hi 😁, this commit has the basic classes.
pls, check if they are ok.
If everything is ok, what would be the interactions with the registers? (read, write?).
A new class should be needed for the interactions?
@Rahix
Copy link
Owner

Rahix commented Apr 14, 2020

Hi, sorry for the late response ... I think the code looks good, although I want to mention one thing: The RegisterMap class currently has methods to add and remove registers. I'd remove them as the register-map is more meant to be a static lookup-list, not something which can be dynamically modified.
@demonpo
Register classes
c79bbdd 
Classes to store information about registers and interact with them

Signed-off-by: Daniel Garcia <demonpogp@gmail.com>
@demonpo
Copy link
Contributor Author

demonpo commented Apr 27, 2020

hi @Rahix 👋, check the new commit.
It has some working interactions (read and write) for 32bits processors.
The code will need refactoring for sure 😅 .
Tell me what you think about this approach.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@demonpo @Rahix