Skip to content

refactor: upgrade and rewrite #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 29, 2023
Merged

refactor: upgrade and rewrite #16

merged 9 commits into from
Aug 29, 2023

Conversation

aoor9
Copy link
Contributor

@aoor9 aoor9 commented Aug 11, 2023 •
edited
Loading

@Rabbitzzc Hello. Since last year this project has not been maintained. So, in this PR, I:

  • upgraded dependencies to solve vulnerabilities
  • refactored all files in src folder to full Typescript, so classes are strictly typed and singularly importable
  • fixed ESLint configuration after encountering some issues
  • added Prettier to beautify code

Please review this ASAP
@Rabbitzzc
Copy link
Owner

ok. I will review in one week. Recently, I have been busy with work.
@Rabbitzzc
Copy link
Owner

In general, we recommend using one commit msg
@aoor9
Copy link
Contributor Author

aoor9 commented Aug 29, 2023

What does it mean? You want me to submit a new PR with only one commit?
@Rabbitzzc Rabbitzzc merged commit 0123f2e into Rabbitzzc:master Aug 29, 2023
@Rabbitzzc
Copy link
Owner

1.2.0 published.... It don't take the static method... but merged some configs.. Thanks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@aoor9 @Rabbitzzc