Skip to content

README.rst: fix syntax errors #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2021
Merged

README.rst: fix syntax errors #32

merged 1 commit into from
Dec 8, 2021

Conversation

@benpicco
Copy link
Contributor

@benpicco benpicco commented Dec 7, 2021

When I tried to follow the example I found some issues

  • native has no flash function
  • it's Ifconfig not ifconfig
  • the ping command misses closing parens
@benpicco benpicco requested review from fjmolinas and miri64 and removed request for miri64 December 7, 2021 20:50
fjmolinas
fjmolinas reviewed Dec 8, 2021
View reviewed changes
@fjmolinas
Copy link
Contributor

fjmolinas commented Dec 8, 2021

Thanks for the fixes! I would rather leave the ctrl.flash command though
@miri64
Copy link
Member

miri64 commented Dec 8, 2021

Maybe we should add doctests for the readme :D.
fjmolinas
fjmolinas approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK
@miri64 miri64 merged commit 4d30bb4 into RIOT-OS:master Dec 8, 2021
@benpicco benpicco deleted the doc_fix branch December 8, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@benpicco @fjmolinas @miri64