refactor: rm nodeInfo from computeBestCombination

[DSFans2014]

What type of PR is this?

What this PR does / why we need it:
get CustomInfo directly from ContainerDevices

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[hami-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DSFans2014
Once this PR has been reviewed and has the lgtm label, please assign fouof for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the device allocation logic by streamlining how device information is accessed within the computeBestCombination functions. By removing a redundant parameter and directly utilizing existing data, the change improves code clarity and reduces unnecessary dependencies, making the device management code more efficient and easier to maintain.

Highlights

• Refactoring computeBestCombination functions: The nodeInfo parameter has been removed from the computeBestCombination and computeBestCombination910C function signatures, simplifying their interfaces.
• Direct access to CustomInfo: Device custom information (CustomInfo) is now accessed directly from the containerDevices parameter within the computeBestCombination function, eliminating the need for the nodeInfo parameter.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• pkg/device/ascend/device.go
  • Removed nodeInfo parameter from computeBestCombination and computeBestCombination910C function calls.
  • Updated computeBestCombination function signature to no longer accept nodeInfo.
  • Modified computeBestCombination to retrieve CustomInfo directly from containerDevices instead of using nodeInfo.
  • Updated computeBestCombination910C function signature to no longer accept nodeInfo.

Activity

• No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag	Coverage Δ
unittests	51.51% <100.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/device/ascend/device.go	82.02% <100.00%> (-0.20%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Code Review

This pull request refactors computeBestCombination and computeBestCombination910C to remove the nodeInfo parameter, simplifying the function signatures. The logic is updated to retrieve CustomInfo directly from ContainerDevices, which is a good improvement for code clarity and efficiency. I've added one comment to suggest a minor refactoring for better readability.