prevent assignment of duplicate labels to agents #3042
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes/directory (if appropriate)docs/outline.tomlfor API reference docs (if appropriate)What does this PR change?
This PR attempts to prevent the situation where an agent has duplicate labels.
Why is this PR important?
While testing #3000 , I noticed something surprising...it's possible for duplicates to exist in an agent's set of labels:
For example:
prefect agent start \ -t ${PREFECT_RUNNER_TOKEN} \ --label 'i-am-duplicated' \ --label 'i-am-duplicated' \ --label 'i-am-duplicated'I'm not sure if this would cause any problems today, but I could see it causing these types of problems:
+nbox like in the screenshot aboveSo, I'm not aware of anything that is not working well today because of this, but I think this change might be a minor way to prevent some weird cases in the future.
Thanks for your time and consideration.