-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fix tooltip for variable expansion and include description #25112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tooltip for variable expansion and include description #25112
Conversation
Fixes the tooltip for non-scoped variables to include the type and variable name like it does for scoped variables. Also includes the variable description if present on the variable object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 2 style comment.
(Since it is very small PR you can add descriptions to some system variables where absent if you want.)
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Show resolved
Hide resolved
Co-authored-by: Ilya <darpa@yandex.ru>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Updated PSES PR so that this will work if merged. |
📣 Hey @jborean93, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
Thanks for the review and merge. |
Thank you @iSazonov ! |
PR Summary
Fixes the tooltip for non-scoped variables to include the type and variable name like it does for scoped variables. Also includes the variable description if present on the variable object.
PR Context
It looks like there is a bug where the tooltip was built for a variable but not included in the completion result, this PR makes sure that isn't thrown away.
It also makes a further change to include the variable description if it's present. This may not be used for user variables but there are a few builtin variables where is a description and would be nice to include in the tooltip.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).