Solve the problem of fetching prediction and make data dim configurable#772
Merged
kuke merged 2 commits intoPaddlePaddle:developfrom Mar 27, 2018
Merged
Solve the problem of fetching prediction and make data dim configurable#772kuke merged 2 commits intoPaddlePaddle:developfrom
kuke merged 2 commits intoPaddlePaddle:developfrom
Conversation
pkuyym
reviewed
Mar 26, 2018
| default=1, | ||
| help='The minimum sequence number of a batch data. ' | ||
| '(default: %(default)d)') | ||
| parser.add_argument( |
Contributor
There was a problem hiding this comment.
@zhxfl Seems this value should be calculated by data reader.
Collaborator
Author
There was a problem hiding this comment.
There is a contradiction: After the data reader really begins to read data, it knows the actual dimensions of frame and label data. But before that, the network has been parsed and the right dimensions of feeding data are needed in advance. So the better way is to set this dimension manually.
| default=1024, | ||
| help='Hidden size of lstmp unit. (default: %(default)d)') | ||
| parser.add_argument( | ||
| '--class_num', |
Collaborator
Author
There was a problem hiding this comment.
Explained in last comment.
fluid/DeepASR/model_utils/model.py
Outdated
| label data respectively. And in inference, only `feature` is needed. | ||
|
|
||
| Args: | ||
| frame_dim(int): The frame dimension of feature data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #771